MDCMigration: Style runs data table row heights for MDC migration. #6616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesHollyer
reviewed
Oct 3, 2023
| @@ -48,11 +48,13 @@ $_arrow_size: 16px; | |||
|
|
|||
| tb-data-table-content-row, | |||
| tb-data-table-header-cell { | |||
| height: 44px; | |||
| // Match the size of the touch targets for the checkbox. | |||
| height: 48px; | |||
There was a problem hiding this comment.
I wish the touch target would match our size like all the other parts of mdc-checkbox do. I am ok with this though.
JamesHollyer
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restyle the height of header and rows in the runs data table.
The height of these rows does need to increase compared to current master in order to account for the increase in height of the checkbox touch target. But they don't need to be as tall as they are now compared to current MDCMigration.
The end result is:
Implementation Detail:
padding: 4pxout of content_cell_component and header_cell_component and now make this padding the responsibility of runs_data_data and scalar_card_data_table to specify.padding: 4pxuntil we determine we need to make adjustments to it as well for MDC migration.Here is a sample screenshot but please patch it in and play with it: